Add version 2018-11-27-preview to Microsoft.Insights #4987
Conversation
…6-01-preview to version 2018-11-27-preview
Removed some of the autogenerated files and added the swagger file and examples for the new api.
Made it the same as the rest of the specs
|
If you're a MSFT employee, click this link |
Automation for azure-sdk-for-jsThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-javaThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-nodeThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-rubyThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
aydany
changed the title
|
This changeset introduces a new extension resource in Microsoft.Insights. This resource is modelled as a singleton collection that provides information about the onboarding status of a resource/resource scope to VM Insights, a component of Azure Monitor. The new resource has been reviewed with the ARM review board. This API is not yet enabled in ARM. We were asked to submit this PR and have it approved, before making the manifest changes. |
|
Can one of the admins verify this patch? |
The latest package including support for the new API will be generated.
This required several changes:
- The defintion of Resource used by the other specs was incompatible.
This was because the other resources were tracked and the new ones is
proxy. Defined a new ProxyResource type.
- The ErrorResponse definition was incompatible with the rest of the
specs in the folder. This is actually a bug in the exesiting specs. They
do not respect the contract of { "error": {"code": "", "message": ""}},
i.e., they lack the top-level error element. To work around this issue,
defined a new response type, ResponseWithError, which is compliant
with the latest ARM requirements.
ravbhatnagar
added
the
WaitForARMFeedback
|
This was reviewed in person by Vlad and @KrisBash. Kris - please feel free to sign off if it looks good. |
|
Notified @lmazuel @anuchandy @daschult regarding the SDK generation failure and waiting for their update. |
|
@AutorestCI rebuild |
|
@sarangan12 @aydany I added a commit to the PR to workaround a bug in our CI, because the last commit message contained a "{" character. |
|
@lmazuel Thank you! |
|
@sarangan12 What else do we need to resolve to complete this PR? Thanks! |
| }, | ||
| "description": "The onboarding status for the resource. Note that, a higher level scope, e.g., resource group or subscription, is considered onboarded if at least one resource under it is onboarded." | ||
| }, | ||
| "dataStatus": { |
There was a problem hiding this comment.
So, dataStatus is an aggregate in the case of multiple destinations? I.e. if the VM were onboarded to multiple destinations, and only sending to one, it would still be present? Is this enough fidelity or should the status be a property of the destination?
KrisBash
added
ARMSignedOff
* Adds base for updating Microsoft.Insights from version preview/2018-06-01-preview to version 2018-11-27-preview
* Updates readme
* Updates API version in new specs and examples
* Add initial swagger
Removed some of the autogenerated files and added the swagger file and
examples for the new api.
* Remove extra / from examples
* Fix swagger file
* Improve docs
* Update resource model
Made it the same as the rest of the specs
* Fix the resource data model: no location and tags
* Fix readme
* Generate the latest package
The latest package including support for the new API will be generated.
This required several changes:
- The defintion of Resource used by the other specs was incompatible.
This was because the other resources were tracked and the new ones is
proxy. Defined a new ProxyResource type.
- The ErrorResponse definition was incompatible with the rest of the
specs in the folder. This is actually a bug in the exesiting specs. They
do not respect the contract of { "error": {"code": "", "message": ""}},
i.e., they lack the top-level error element. To work around this issue,
defined a new response type, ResponseWithError, which is compliant
with the latest ARM requirements.
* Update Python version
If you are a MSFT employee you can view your work branch via this link.
Contribution checklist: